Gentoo Forums
Gentoo Forums
Gentoo Forums
Quick Search: in
[SOLVED]gnome-extra/cjs-4.0.0-r1 fails/missing seperator
View unanswered posts
View posts from last 24 hours

 
Reply to topic    Gentoo Forums Forum Index Portage & Programming
View previous topic :: View next topic  
Author Message
alamahant
Veteran
Veteran


Joined: 23 Mar 2019
Posts: 1767

PostPosted: Mon Aug 05, 2019 2:02 pm    Post subject: [SOLVED]gnome-extra/cjs-4.0.0-r1 fails/missing seperator Reply with quote

Hi Guys


When emerging cinnamon in my ~amd64 I get this error during cjs compilation
Code:

>>> Source configured.
>>> Compiling source in /var/tmp/portage/gnome-extra/cjs-4.0.0-r1/work/cjs-4.0.0 ...
make -j9
Makefile:3628: *** missing separator.  Stop.
 * ERROR: gnome-extra/cjs-4.0.0-r1::gentoo failed (compile phase):
 *   emake failed


There is a bug reported since May
https://bugs.gentoo.org/686374

I went and had a look in the Makefile in
Code:

/var/tmp/portage/gnome-extra/cjs-4.0.0-r1/work/cjs-4.0.0

Near line 3628 i have this:
Code:

  $(foreach gir,$(TEST_INTROSPECTION_GIRS),$(eval $(call introspection-scanner,$(gir))))
 3628 @CODE_COVERAGE_RULES@
 3629
 3630 #%.test: %.js installed-tests/minijasmine.test.in Makefile
 3631 # $(AM_V_GEN)$(MKDIR_P) $(@D) && \
 3632 # $(SED) -e s,@pkglibexecdir\@,$(pkglibexecdir),g \
 3633 #   -e s,@name\@,$(notdir $<), \
 3634 #   < $(srcdir)/installed-tests/minijasmine.test.in > $@.tmp && \
 3635 # mv $@.tmp $@
 3636
 3637 #%.test: % installed-tests/script.test.in Makefile
 3638 # $(AM_V_GEN)$(MKDIR_P) $(@D) && \
 3639 # $(SED) -e s,@pkglibexecdir\@,$(pkglibexecdir), \
 3640 #   -e s,@name\@,$(notdir $<), \
 3641 #   < $(srcdir)/installed-tests/script.test.in > $@.tmp && \
 3642 # mv $@.tmp $@
 3643
 3644 /var/tmp/portage/gnome-extra/cjs-4.0.0-r1/work/cjs-4.0.0prepare-release-tag: Makefile
 3645   git tag -m "Tag $(TAG_VERSION)" -a $(TAG_PREFIX)$(TAG_VERSION)
 3646

Line 3628 is this annotation:
Code:

@CODE_COVERAGE_RULES@

What does that mean and Is it safe to comment it OUT?

And if yes how do I instruct emerge to NOT re-EXTRACT the package but use the already extracted one with my modification in the Makefile?
Thanks a lot.......
Best Regards
:D


Last edited by alamahant on Tue Aug 06, 2019 7:23 pm; edited 1 time in total
Back to top
View user's profile Send private message
fedeliallalinea
Administrator
Administrator


Joined: 08 Mar 2003
Posts: 27120
Location: here

PostPosted: Mon Aug 05, 2019 3:18 pm    Post subject: Reply with quote

See https://github.com/linuxmint/cjs/issues/78 you can try if patch can be applied to 4.0.0 release
_________________
Questions are guaranteed in life; Answers aren't.
Back to top
View user's profile Send private message
Hu
Moderator
Moderator


Joined: 06 Mar 2007
Posts: 17779

PostPosted: Tue Aug 06, 2019 1:35 am    Post subject: Re: gnome-extra/cjs-4.0.0-r1 fails/missing seperator Reply with quote

alamahant wrote:
Code:
 3628 @CODE_COVERAGE_RULES@
What does that mean and Is it safe to comment it OUT?
It appears to be a placeholder that was supposed to be expanded to some Makefile text, but was instead left untouched. It is probably safe to delete.
alamahant wrote:
And if yes how do I instruct emerge to NOT re-EXTRACT the package but use the already extracted one with my modification in the Makefile?
You don't, because then the next time you emerge this package, you will have to do that again. If you really want to manually fix this every time, use ebuild to run the remaining phases. However, the preferred solution would be to have the ebuild patch this file so that the fix happens automatically with every build.
Back to top
View user's profile Send private message
alamahant
Veteran
Veteran


Joined: 23 Mar 2019
Posts: 1767

PostPosted: Tue Aug 06, 2019 12:55 pm    Post subject: Reply with quote

Thank you guys for your kind replies.
Hu you mention:
Quote:

However, the preferred solution would be to have the ebuild patch this file so that the fix happens automatically with every build.

Forgive my ignorance but how do I do this?
Thanks you both for your bearing with me.


Last edited by alamahant on Tue Aug 06, 2019 1:00 pm; edited 1 time in total
Back to top
View user's profile Send private message
fedeliallalinea
Administrator
Administrator


Joined: 08 Mar 2003
Posts: 27120
Location: here

PostPosted: Tue Aug 06, 2019 12:59 pm    Post subject: Reply with quote

alamahant wrote:
Forgive my ignorance but how do I do this?
Thanks you both for your bearing with me.

https://wiki.gentoo.org/wiki/Patches
_________________
Questions are guaranteed in life; Answers aren't.
Back to top
View user's profile Send private message
alamahant
Veteran
Veteran


Joined: 23 Mar 2019
Posts: 1767

PostPosted: Tue Aug 06, 2019 3:30 pm    Post subject: Reply with quote

It didnt work.
I created the patch with git, placed it in /etc/portage/patches emerged gnome-extra/cjs but got the same exact error
Nevertheless thank you so much for your help because I learnt a bit about portage patches.
I knew nothing before
Thanks again
:D :)
Back to top
View user's profile Send private message
alamahant
Veteran
Veteran


Joined: 23 Mar 2019
Posts: 1767

PostPosted: Tue Aug 06, 2019 7:22 pm    Post subject: Reply with quote

I did it!
Apparently the patch approach was not appropriate BUT in the Bug report I saw a rather mispeled comment about downgrading to =sys-devel/autoconf-archive-2018.03.13.
Sure enough:
Code:

emerge -1av =sys-devel/autoconf-archive-2018.03.13
emerge -1av gnome-extra/cjs
emerge -1av =sys-devel/autoconf-archive-2019.01.06
emerge -aq cinnamon

.....did the trick...
I installed Cinnamon.
:D :)
Back to top
View user's profile Send private message
Hu
Moderator
Moderator


Joined: 06 Mar 2007
Posts: 17779

PostPosted: Wed Aug 07, 2019 12:44 am    Post subject: Reply with quote

When you tried to use the patch, did the ebuild detect and apply your patch? It would print a message if it did.
Back to top
View user's profile Send private message
alamahant
Veteran
Veteran


Joined: 23 Mar 2019
Posts: 1767

PostPosted: Wed Aug 07, 2019 6:33 am    Post subject: Reply with quote

Yes it did...
But I got the same exact error about seperator missing..
And the @CODE_COVERAGE_RULES@ again reappeared in the Makefile although I had commented it out in Makefile-test.am which was the only place I could grep it.
Back to top
View user's profile Send private message
guimaluf
n00b
n00b


Joined: 12 Jun 2018
Posts: 3

PostPosted: Mon Dec 02, 2019 12:13 am    Post subject: Reply with quote

alamahant wrote:
I did it!
Apparently the patch approach was not appropriate BUT in the Bug report I saw a rather mispeled comment about downgrading to =sys-devel/autoconf-archive-2018.03.13.
Sure enough:
Code:

emerge -1av =sys-devel/autoconf-archive-2018.03.13
emerge -1av gnome-extra/cjs
emerge -1av =sys-devel/autoconf-archive-2019.01.06
emerge -aq cinnamon

.....did the trick...
I installed Cinnamon.
:D :)


thank you. it worked for me!
Back to top
View user's profile Send private message
Display posts from previous:   
Reply to topic    Gentoo Forums Forum Index Portage & Programming All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum